SlideShare uma empresa Scribd logo
1 de 10
Baixar para ler offline
Code Review: Drinking Game
Code Review: zlfstnw
Nakijken van programmeerwerk door ontwikkelaars om
de kwaliteit van de opgeleverde code te bewaken
The only valid measurement of code quality:
code
review
wtf
wtf
good code
wtf
wtf is
this shit
wtf
wtf
dude,
wtf!
code
review
bad code
(c) 2008 focus shift
[line 67]
Code Reviews be like:
waarom doe je dit?
«legt stukje code uit»
nee... als beroep?
"That's what I do:
I drink and

I know things"
–Tyrion Lannister
Drinking
Game?
artiest
knipoogt naar
camera
slechte grap
van land bij
resultaten
valse NOOT
12 punten voor
buurland
presentator
wisselt
kostuum
presentator
flirt
5 mensen zingen
on stage
wind machine
blaast
achtergrond–
koor fluit
artiest zonder
schoenen
artiest
verliest
kledingstuk
folklore

outfit
Finale Drinking Game 2016
1 slok 2 slokken ad fundum
Java
TODO comment
gegenereerd
commentaar
reviewer 

zegt WTF
meer dan 2
generics
parameters
> 3 geneste
blokken diep
Leeg

catch blok
onnodig
complexe code
(framework-itis)
Random ipv.
secureRandom
gebruiken
catch

Null Pointer
Exception
> 5 geneste
blokken diep
Hongaarse
notatie
merge conflict
markers nog in
code
1 slok 2 slokken ad fundum
.net
code review
drinking
game
JavaScript
Code Review Drinking Game
JavaScript Code Review Drinking Game

Mais conteúdo relacionado

Mais de Martijn Dashorst

Java Serialization Deep Dive
Java Serialization Deep DiveJava Serialization Deep Dive
Java Serialization Deep DiveMartijn Dashorst
 
Scrum: van praktijk naar onderwijs
Scrum: van praktijk naar onderwijsScrum: van praktijk naar onderwijs
Scrum: van praktijk naar onderwijsMartijn Dashorst
 
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)Who Automates the Automators? (Quis Automatiet Ipsos Automates?)
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)Martijn Dashorst
 
Wicket 10 years and beyond
Wicket   10 years and beyond Wicket   10 years and beyond
Wicket 10 years and beyond Martijn Dashorst
 
Apache Wicket and Java EE sitting in a tree
Apache Wicket and Java EE sitting in a treeApache Wicket and Java EE sitting in a tree
Apache Wicket and Java EE sitting in a treeMartijn Dashorst
 
Vakmanschap is meesterschap
Vakmanschap is meesterschapVakmanschap is meesterschap
Vakmanschap is meesterschapMartijn Dashorst
 
Keep your Wicket application in production
Keep your Wicket application in productionKeep your Wicket application in production
Keep your Wicket application in productionMartijn Dashorst
 
Wicket In Action - oredev2008
Wicket In Action - oredev2008Wicket In Action - oredev2008
Wicket In Action - oredev2008Martijn Dashorst
 
Guide To Successful Graduation at Apache
Guide To Successful Graduation at ApacheGuide To Successful Graduation at Apache
Guide To Successful Graduation at ApacheMartijn Dashorst
 
Apache Wicket: Web Applications With Just Java
Apache Wicket: Web Applications With Just JavaApache Wicket: Web Applications With Just Java
Apache Wicket: Web Applications With Just JavaMartijn Dashorst
 

Mais de Martijn Dashorst (15)

Java Serialization Deep Dive
Java Serialization Deep DiveJava Serialization Deep Dive
Java Serialization Deep Dive
 
Scrum: van praktijk naar onderwijs
Scrum: van praktijk naar onderwijsScrum: van praktijk naar onderwijs
Scrum: van praktijk naar onderwijs
 
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)Who Automates the Automators? (Quis Automatiet Ipsos Automates?)
Who Automates the Automators? (Quis Automatiet Ipsos Automates?)
 
De schone coder
De schone coderDe schone coder
De schone coder
 
Wicket 10 years and beyond
Wicket   10 years and beyond Wicket   10 years and beyond
Wicket 10 years and beyond
 
Apache Wicket and Java EE sitting in a tree
Apache Wicket and Java EE sitting in a treeApache Wicket and Java EE sitting in a tree
Apache Wicket and Java EE sitting in a tree
 
The State of Wicket
The State of WicketThe State of Wicket
The State of Wicket
 
Wicket 2010
Wicket 2010Wicket 2010
Wicket 2010
 
Vakmanschap is meesterschap
Vakmanschap is meesterschapVakmanschap is meesterschap
Vakmanschap is meesterschap
 
Keep your Wicket application in production
Keep your Wicket application in productionKeep your Wicket application in production
Keep your Wicket application in production
 
Wicket In Action - oredev2008
Wicket In Action - oredev2008Wicket In Action - oredev2008
Wicket In Action - oredev2008
 
Guide To Successful Graduation at Apache
Guide To Successful Graduation at ApacheGuide To Successful Graduation at Apache
Guide To Successful Graduation at Apache
 
Wicket In Action
Wicket In ActionWicket In Action
Wicket In Action
 
Apache Wicket: Web Applications With Just Java
Apache Wicket: Web Applications With Just JavaApache Wicket: Web Applications With Just Java
Apache Wicket: Web Applications With Just Java
 
Wicket Live on Stage
Wicket Live on StageWicket Live on Stage
Wicket Live on Stage
 

Code review drinking game