pdf export for jam's drupal camp. also at https://github.com/zendoodles/slide-decks/blob/jam/patch-review/index.html

1. Patch Reviews
Thanks ZenDoodles and xjm

2. YesCT
Cathy Theys
@YesCT
Cheppers, Gittip
I review patches, mostly for core these days.
And do other stuff like plan sprints and mentor.

3. (https://www.youtube.com/watch?v=NvV38nJObIE&t=12m57s)

5. Getting patch reviews
Also: how to find reviews

6. Be specific,
what kind of review?

7. Use tags
needs JavaScript review
needs architectural review,
needs usability review,
needs manual testing,
needs screenshot

8. Up-to-date Issue Summary
https://drupal.org/contributor-tasks/write-issue-summary

13. Automatic instructions
work in progress at
https://drupal.org/node/2013222

14. Contributor task
documents
http://drupal.org/contributor-tasks/review
http://drupal.org/contributor-tasks/do-accessibility-review

15. Metas

18. simplytest.me url
pattern is:
/project/drupal/8.x?
patch[]=
http://simplytest.me/qa#developers

19. Give good reviews

20. Doing patch reviews

21. Finding issues to
review

22. first simple! success!
novice?
initiatives
metas?
focus?

28. Core initiatives
https://drupal.org/community-initiatives/drupal-core
and https://drupal.org/node/2107085

38. Doing patch reviews

39. Full frontal nicety

40. Supportive
specific
include links
support improvement
ask questions
educate

43. http://dreditor.org

68. Does it work?
fixes the issue
stays in scope
no regressions

77. Edit

88. Does it make sense?
readable?
comments?
is there a better way?

95. Strategy
Scale
say what
say how

96. Strategy
Kinds of reviews
update the issue summary
update needs tags

97. Process
cannot unread
perfect is enemy of good

101. documentation
issue summary
time
in-code API docs (1354)
hook_help()
change records
http://drupal.org/list-changes/drupal

102. Performance
Don't guess
profile!

103. Accessibility

104. bug
WCAG
ATAG
text color contrast
form fields are labeled
keyboard-usable (javascript)

105. Usability
UI changes need usability
review
before and after screenshots

106. Testing
check coverage
ask for new tests
verify tests-only fails

107. Coding Style
no tabs, trailing
1354
link! to docs

108. drupal.org/documentation/git/interdiff

109. Read and check
concerns?
addressed?

110. read, read, read
fix simple
for scope
for understanding

111. IDE

112. Resources
drupalize.me/guides/drupal-community-tools-and-core-mentoring

114. Resources
drupalladder.org/

115. Resources
drupal.org/contributortasks/review
xjm.drupalgardens.com/reviewguide

116. Action
drupal mentoring office hours
#drupal-contribute
drupical.com

117. Thanks!
https://drupal.org/node/2013222
https://drupal.org/core-mentoring