Alex Fernández - Has anyone else seen your code? - Codemotion Berlin 2018
•
1 gostou•379 visualizações
The document discusses the importance of code reviews and improving code quality. It notes that bad code can have serious consequences like software bugs that cost $60 billion. It advocates for practices like peer code reviews, treating people well during the review process, and explaining code changes, which can help disseminate knowledge and catch issues early. The document also warns that relying solely on senior reviews can create bottlenecks and that reviews are a process of continuous improvement, not a single event.
Recomendados
Recomendados
Mais conteúdo relacionado
Semelhante a Alex Fernández - Has anyone else seen your code? - Codemotion Berlin 2018
Semelhante a Alex Fernández - Has anyone else seen your code? - Codemotion Berlin 2018 (20)
Mais de Codemotion
Mais de Codemotion (20)
Último
Último (20)
Alex Fernández - Has anyone else seen your code? - Codemotion Berlin 2018
- 1. HAS ANYONE ELSE SEENHAS ANYONE ELSE SEEN
- 2. HAS ANYONE ELSE SEENHAS ANYONE ELSE SEEN YOUR CODE?YOUR CODE?
- 3. HAS ANYONE ELSE SEENHAS ANYONE ELSE SEEN YOUR CODE?YOUR CODE? CODEMOTION BERLIN 2018-11-21CODEMOTION BERLIN 2018-11-21
- 4. YOUR HOST TODAYYOUR HOST TODAY @pinchito
- 5. WHAT WE WILL COVERWHAT WE WILL COVER
- 6. WHAT WE WILL COVERWHAT WE WILL COVER BadCodeWillKillYou
- 7. WHAT WE WILL COVERWHAT WE WILL COVER BadCodeWillKillYou DeployingSpiders
- 8. WHAT WE WILL COVERWHAT WE WILL COVER BadCodeWillKillYou DeployingSpiders ZenandtheArtofCodeReviews
- 9. WHAT WE WILL COVERWHAT WE WILL COVER BadCodeWillKillYou DeployingSpiders ZenandtheArtofCodeReviews EditorialProcess
- 10. WHAT WE WILL COVERWHAT WE WILL COVER BadCodeWillKillYou DeployingSpiders ZenandtheArtofCodeReviews EditorialProcess Conclusions
- 11. WHY ME?WHY ME?
- 16. CODE CAN (AND WILL) KILL YOUCODE CAN (AND WILL) KILL YOU
- 17. BAD CODE IS OUT TO GET YOU!BAD CODE IS OUT TO GET YOU!
- 18. SOFTWARE BUGS COST $60 BILLIONSOFTWARE BUGS COST $60 BILLION
- 19. SOFTWARE BUGS COST $60 BILLIONSOFTWARE BUGS COST $60 BILLION
- 20. SOFTWARE BUGS COST $60 BILLIONSOFTWARE BUGS COST $60 BILLION ...intheUSin2002
- 26. STATE OF THE ART SENSORSSTATE OF THE ART SENSORS
- 27. STATE OF THE ART SENSORSSTATE OF THE ART SENSORS VS PRIMATE IN METAL BOXVS PRIMATE IN METAL BOX
- 28. STATE OF THE ART SENSORSSTATE OF THE ART SENSORS VS PRIMATE IN METAL BOXVS PRIMATE IN METAL BOX
- 30. APE WINSAPE WINS
- 31. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS
- 32. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo
- 33. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM
- 34. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan
- 35. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW
- 36. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla
- 37. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla ...
- 38. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla ... Seat?
- 39. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla ... Seat? Dacia?
- 40. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla ... Seat? Dacia? Perodua??
- 41. SELF-DRIVING CAR MANUFACTURERSSELF-DRIVING CAR MANUFACTURERS Waymo GM Nissan BMW Tesla ... Seat? Dacia? Perodua?? Saipa???
- 45. DO YOU KNOW WHAT YOU DEPLOY?DO YOU KNOW WHAT YOU DEPLOY?
- 46. DO YOU KNOW WHAT YOU DEPLOY?DO YOU KNOW WHAT YOU DEPLOY? OFTEN WE DO NOT KNOW!OFTEN WE DO NOT KNOW!
- 47. IT MAY BE WEIRD STUFFIT MAY BE WEIRD STUFF
- 48. IT MAY BE WEIRD STUFFIT MAY BE WEIRD STUFF (POTENTIALLY VERY WEIRD)(POTENTIALLY VERY WEIRD)
- 51. SPOILER ALERTSPOILER ALERT IT'S A HUMAN HEAD!IT'S A HUMAN HEAD!
- 59. HALL OF TORTURED SOULSHALL OF TORTURED SOULS
- 60. LINUX 4.17.3: 6 MLOCLINUX 4.17.3: 6 MLOC
- 61. LINUX 4.17.3: 6 MLOCLINUX 4.17.3: 6 MLOC $ grep -ir fuck linux-4.17.3 | wc -l 29 $ grep -ir kludge linux-4.17.3 | wc -l 110 $ grep -ir cludge linux-4.17.3 | wc -l 1 $ grep -ir crap linux-4.17.3 | wc -l 195 $ grep -r TODO linux-4.17.3 | wc -l 4825
- 62. LINUX 4.17.3: 6 MLOCLINUX 4.17.3: 6 MLOC $ grep -ir fuck linux-4.17.3 | wc -l 29 $ grep -ir kludge linux-4.17.3 | wc -l 110 $ grep -ir cludge linux-4.17.3 | wc -l 1 $ grep -ir crap linux-4.17.3 | wc -l 195 $ grep -r TODO linux-4.17.3 | wc -l 4825 ## Some Highlights * Wirzenius wrote this portably, Torvalds fucked it up :-) /* !!!! THIS IS A PIECE OF SHIT MADE BY ME !!! */
- 63. NODE.JS 10.5.0: 3 MLOCNODE.JS 10.5.0: 3 MLOC
- 64. NODE.JS 10.5.0: 3 MLOCNODE.JS 10.5.0: 3 MLOC $ grep -ir fuck node-v10.5.0 | wc -l 25 $ grep -ir kludge node-v10.5.0 | wc -l 22 $ grep -ir crap node-v10.5.0 | grep -v scrap | wc -l 9 $ grep -r TODO node-v10.5.0 | wc -l 2904
- 65. NODE.JS 10.5.0: 3 MLOCNODE.JS 10.5.0: 3 MLOC $ grep -ir fuck node-v10.5.0 | wc -l 25 $ grep -ir kludge node-v10.5.0 | wc -l 22 $ grep -ir crap node-v10.5.0 | grep -v scrap | wc -l 9 $ grep -r TODO node-v10.5.0 | wc -l 2904 ## Some Highlights * **help:** fuck it. just hard-code it ([d5d5085] (https://github.com/zkat/npx/commit/d5d5085)) * IOW it's all just a clusterfuck and we should think of something that makes slightly more sense.
- 66. JAVA 10.0.1: 3.5 MLOCJAVA 10.0.1: 3.5 MLOC
- 67. JAVA 10.0.1: 3.5 MLOCJAVA 10.0.1: 3.5 MLOC $ grep -ir fuck java-10.0.1 | wc -l 1 $ grep -ir kludge java-10.0.1 | wc -l 16 $ grep -ir crap java-10.0.1 | grep -v scrap | wc -l 3 $ grep -r TODO java-10.0.1 | wc -l 2155
- 68. JAVA 10.0.1: 3.5 MLOCJAVA 10.0.1: 3.5 MLOC $ grep -ir fuck java-10.0.1 | wc -l 1 $ grep -ir kludge java-10.0.1 | wc -l 16 $ grep -ir crap java-10.0.1 | grep -v scrap | wc -l 3 $ grep -r TODO java-10.0.1 | wc -l 2155 ## Some Highlights if (uri == null || uri.length() == 0) // crap. the NamespaceContext interface is broken // forces us to clear out crap up to the next * TODO: wrapping message needs easier. in particular properties and attachments.
- 69. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 70. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 71. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 72. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 73. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 74. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT
- 75. UNIT TESTS ARE GREATUNIT TESTS ARE GREAT WHEN SOMEONE REVIEWS THEM!WHEN SOMEONE REVIEWS THEM!
- 76. EXTERNAL TESTS ARE AWESOMEEXTERNAL TESTS ARE AWESOME
- 77. EXTERNAL TESTS ARE AWESOMEEXTERNAL TESTS ARE AWESOME Buthavetoberepeatedeverytime
- 78. EXTERNAL TESTS ARE AWESOMEEXTERNAL TESTS ARE AWESOME Buthavetoberepeatedeverytime Labor-intensive
- 79. EXTERNAL TESTS ARE AWESOMEEXTERNAL TESTS ARE AWESOME Buthavetoberepeatedeverytime Labor-intensive Microsoft:1QA/devinthe90s
- 80. EXTERNAL TESTS ARE AWESOMEEXTERNAL TESTS ARE AWESOME Buthavetoberepeatedeverytime Labor-intensive Microsoft:1QA/devinthe90s Today:1QA/3devs
- 81. WHEN PAIR PROGRAMMING IS NOT ENOUGHWHEN PAIR PROGRAMMING IS NOT ENOUGH
- 82. EVEN REMOTE PAIR PROGRAMMINGEVEN REMOTE PAIR PROGRAMMING
- 83. ZEN AND THE ARTZEN AND THE ART OF CODE REVIEWOF CODE REVIEW
- 84. JUDGED BY A JURY OF YOUR PEERSJUDGED BY A JURY OF YOUR PEERS
- 91. DO NOT RELY SOLELY ON SENIOR REVIEWDO NOT RELY SOLELY ON SENIOR REVIEW
- 92. SENIOR REVIEW CREATESSENIOR REVIEW CREATES A CHOKE POINT A CHOKE POINT
- 93. SENIOR REVIEW CREATESSENIOR REVIEW CREATES A CHOKE POINT A CHOKE POINT
- 94. SENIOR REVIEW CREATESSENIOR REVIEW CREATES A CHOKE POINT A CHOKE POINT
- 95. SENIOR REVIEW CREATESSENIOR REVIEW CREATES A CHOKE POINT A CHOKE POINT
- 96. SENIOR REVIEW CREATESSENIOR REVIEW CREATES A CHOKE POINT A CHOKE POINT
- 97. MANDATORY FEYNMAN MISQUOTEMANDATORY FEYNMAN MISQUOTE Icouldn'texplainmycodetoajunior.That meansIdon'treallyunderstandmycode. RichardFeynman
- 98. ENCOURAGE JUNIORS TO ASK ONE QUESTIONENCOURAGE JUNIORS TO ASK ONE QUESTION
- 99. ENCOURAGE JUNIORS TO ASK ONE QUESTIONENCOURAGE JUNIORS TO ASK ONE QUESTION
- 100. ENCOURAGE JUNIORS TO ASK ONE QUESTIONENCOURAGE JUNIORS TO ASK ONE QUESTION Youmaylearnsomething
- 101. ENCOURAGE JUNIORS TO ASK ONE QUESTIONENCOURAGE JUNIORS TO ASK ONE QUESTION Youmaylearnsomething ...ornot
- 102. TOO MANY PRIMA DONNAS ALREADYTOO MANY PRIMA DONNAS ALREADY
- 104. TREAT PEOPLE WELLTREAT PEOPLE WELL
- 105. TREAT PEOPLE WELLTREAT PEOPLE WELL Donotgiveorders;askquestions
- 106. TREAT PEOPLE WELLTREAT PEOPLE WELL Donotgiveorders;askquestions Maybeaskquestionsinsteadofgivingorders?
- 107. TREAT PEOPLE WELLTREAT PEOPLE WELL Donotgiveorders;askquestions Maybeaskquestionsinsteadofgivingorders? Isn'titfastertochangeitthantoargue?
- 108. TREAT PEOPLE WELLTREAT PEOPLE WELL Donotgiveorders;askquestions Maybeaskquestionsinsteadofgivingorders? Isn'titfastertochangeitthantoargue? Couldyouacceptcriticismgracefully?
- 109. DON'T TROLL PEOPLEDON'T TROLL PEOPLE
- 110. BENEFITSBENEFITS
- 115. EXPLAINING YOUR CODE IS GOODEXPLAINING YOUR CODE IS GOOD
- 116. EXPLAINING YOUR CODE IS GOODEXPLAINING YOUR CODE IS GOOD
- 117. EXPLAINING YOUR CODE IS GOODEXPLAINING YOUR CODE IS GOOD Ifyoudon'tlearnanythingyou'redoingitwrong
- 121. VOLKSWAGEN SCENARIOVOLKSWAGEN SCENARIO Blameisspread Otherpeoplereviewed Gostraighttothesolutions
- 122. IF REVIEWS GIVE YOU TROUBLEIF REVIEWS GIVE YOU TROUBLE
- 123. IF REVIEWS GIVE YOU TROUBLEIF REVIEWS GIVE YOU TROUBLE Maybeyouhavesomeissuestoworkwith?
- 124. IF REVIEWS GIVE YOU TROUBLEIF REVIEWS GIVE YOU TROUBLE Maybeyouhavesomeissuestoworkwith? Corollary:
- 125. IF REVIEWS GIVE YOU TROUBLEIF REVIEWS GIVE YOU TROUBLE Maybeyouhavesomeissuestoworkwith? Corollary: Ifyouwanttoimproveyourdevprocess,doreviews!
- 131. SIX EYESSIX EYES
- 132. EIGHT EYESEIGHT EYES SIX EYESSIX EYES
- 133. EIGHT EYESEIGHT EYES SIX EYESSIX EYES
- 134. EIGHT EYESEIGHT EYES SIX EYESSIX EYES
- 135. CREATE YOUR OWN ADVENTURE!CREATE YOUR OWN ADVENTURE!
- 136. CREATE YOUR OWN ADVENTURE!CREATE YOUR OWN ADVENTURE!
- 137. CREATE YOUR OWN ADVENTURE!CREATE YOUR OWN ADVENTURE!
- 138. CREATE YOUR OWN ADVENTURE!CREATE YOUR OWN ADVENTURE!
- 140. REVIEWS ARE A PROCESS, NOT AREVIEWS ARE A PROCESS, NOT A DESTINATIONDESTINATION Prepareformultipleround-trips
- 142. PEOPLE DEPLOY CODE ALL THE TIMEPEOPLE DEPLOY CODE ALL THE TIME
- 143. PEOPLE DEPLOY CODE ALL THE TIMEPEOPLE DEPLOY CODE ALL THE TIME
- 144. PEOPLE DEPLOY CODE ALL THE TIMEPEOPLE DEPLOY CODE ALL THE TIME "DEPLOY""DEPLOY"
- 145. JUNIORS MAKE GREAT REVIEWERSJUNIORS MAKE GREAT REVIEWERS
- 146. CODE REVIEWS KEEP YOU HONESTCODE REVIEWS KEEP YOU HONEST
- 147. MAKE THE PROCESS EXPLICITMAKE THE PROCESS EXPLICIT