1.
• Burgers
• “Scaling our Code Reviewing” - Sander Bol
• Short break
• “What's new in PHP 7?” - Thijs Feryn
• Office tour
• Drinks
Schedule

2.
Facts

3.
Facts

4.
Facts

5.
Facts

6.
Facts

7.
July 19th 2016 - Behind the Scenes
Sander Bol

8.
Growth

9.
Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes
Source: https://smartbear.com/learn/code-review/what-is-code-review/

10.
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes
Definition

11.
Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes

12.
Definition
Code Review is the act of
consciously and systematically
convening with one’s fellow programmers
to check each other’s code for mistakes

13.
Definition

14.
Definition

15.
Happy accidents?

16.
Common mistakes

17.
What to look for in a review?
● Functionality
● Design
● Readability & Maintainability
● Have you thought about…?

18.
How you should do reviews...
_(ツ)_/¯

19.
Answer me these questions three...
When
to review?
What
to review?
Who
is reviewing?

20.
Pull Request Review
Production
Development

21.
Post-merge Review
Production
Development

22.
What to review

23.
What to review

24.
What to review

25.
Who is reviewing?
?
? X
?
✓
✓
!!
X
✓

26.
Who is reviewing?
?
? X
?
✓
✓
!!
X
✓
Indenting!
Whitespace!
Trailing comma!
Bad naming!
Low test coverage!
Debug code!
Insecure code!
Does not compile!

27.
Who is reviewing?
?
✓ !!
X
✓
Indenting!
Whitespace!
Trailing comma!
Bad naming!
Low test coverage!
Debug code!
Insecure code!
Does not compile!

28.
Answer me these questions three...
When
to review?
What
to review?
Who
is reviewing?

29.
Asking for a review
- Start with the obvious
“The goal of my change is...”
- Limit size of change set
- Reserve time in advance
- Implement any feedback you receive (or explain why not)
- Keep your commits clean
- All tests green!

30.
3 steps Coolblue took

31.
3 steps Coolblue took

32.
3 steps Coolblue took

33.
Tooling
Basic
● Pull request (Github / Bitbucket)
Advanced
● Jetbrains Upsource
● Phabricator Differential
● Reviewable.io (“Github reviews done right”)
● Atlassian Crucible

34.
Remember, remember
1.Start with the obvious.
2.Automate the tedious.
3.Why so serious?

35.
• Burgers
• “Scaling our Code Reviewing” - Sander Bol
• Short break
• “What's new in PHP 7?” - Thijs Feryn
• Office tour
• Drinks
Schedule

36.
Untitled Bob Ross painting.
Image credits
http://dogtalk101.blogspot.nl/2011/05/let-sleeping-dogs-lie.html