O slideshow foi denunciado.
Utilizamos seu perfil e dados de atividades no LinkedIn para personalizar e exibir anúncios mais relevantes. Altere suas preferências de anúncios quando desejar.

Scaling your code review

463 visualizações

Publicada em

Talk given during Coolblue Behind the Scenes on July 19th 2016, explaining what code review is, how to improve the quality of your reviews and what Coolblue learned while scaling this process up to 150 developers.

Publicada em: Software
  • Entre para ver os comentários

Scaling your code review

  1. 1. • Burgers • “Scaling our Code Reviewing” - Sander Bol • Short break • “What's new in PHP 7?” - Thijs Feryn • Office tour • Drinks Schedule
  2. 2. Facts
  3. 3. Facts
  4. 4. Facts
  5. 5. Facts
  6. 6. Facts
  7. 7. July 19th 2016 - Behind the Scenes Sander Bol
  8. 8. Growth
  9. 9. Definition Code Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes Source: https://smartbear.com/learn/code-review/what-is-code-review/
  10. 10. Code Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes Definition
  11. 11. Definition Code Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes
  12. 12. Definition Code Review is the act of consciously and systematically convening with one’s fellow programmers to check each other’s code for mistakes
  13. 13. Definition
  14. 14. Definition
  15. 15. Happy accidents?
  16. 16. Common mistakes
  17. 17. What to look for in a review? ● Functionality ● Design ● Readability & Maintainability ● Have you thought about…?
  18. 18. How you should do reviews... _(ツ)_/¯
  19. 19. Answer me these questions three... When to review? What to review? Who is reviewing?
  20. 20. Pull Request Review Production Development
  21. 21. Post-merge Review Production Development
  22. 22. What to review
  23. 23. What to review
  24. 24. What to review
  25. 25. Who is reviewing? ? ? X ? ✓ ✓ !! X ✓
  26. 26. Who is reviewing? ? ? X ? ✓ ✓ !! X ✓ Indenting! Whitespace! Trailing comma! Bad naming! Low test coverage! Debug code! Insecure code! Does not compile!
  27. 27. Who is reviewing? ? ✓ !! X ✓ Indenting! Whitespace! Trailing comma! Bad naming! Low test coverage! Debug code! Insecure code! Does not compile!
  28. 28. Answer me these questions three... When to review? What to review? Who is reviewing?
  29. 29. Asking for a review - Start with the obvious “The goal of my change is...” - Limit size of change set - Reserve time in advance - Implement any feedback you receive (or explain why not) - Keep your commits clean - All tests green!
  30. 30. 3 steps Coolblue took
  31. 31. 3 steps Coolblue took
  32. 32. 3 steps Coolblue took
  33. 33. Tooling Basic ● Pull request (Github / Bitbucket) Advanced ● Jetbrains Upsource ● Phabricator Differential ● Reviewable.io (“Github reviews done right”) ● Atlassian Crucible
  34. 34. Remember, remember 1.Start with the obvious. 2.Automate the tedious. 3.Why so serious?
  35. 35. • Burgers • “Scaling our Code Reviewing” - Sander Bol • Short break • “What's new in PHP 7?” - Thijs Feryn • Office tour • Drinks Schedule
  36. 36. Untitled Bob Ross painting. Image credits http://dogtalk101.blogspot.nl/2011/05/let-sleeping-dogs-lie.html

×